Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --no-clobber option to CLI #3025

Merged
merged 4 commits into from
Oct 5, 2023
Merged

feat: add --no-clobber option to CLI #3025

merged 4 commits into from
Oct 5, 2023
+13 −1

Conversation

skoriop
Copy link
Contributor

@skoriop skoriop commented Oct 3, 2023 •
edited by styfle
Loading

Marked version: c9ffa64

Markdown flavor: n/a

Description

If the --no-clobber / -n option is set, it throws an error if the output file already exists.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 8:17pm

UziTech
UziTech approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

styfle
styfle approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be nice to add a test for this one too 👍

styfle
styfle reviewed Oct 4, 2023
View reviewed changes
bin/main.js Outdated Show resolved Hide resolved
UziTech
UziTech requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the option to --no-clobber to be consistent with other commands. https://man7.org/linux/man-pages/man1/cp.1.html

styfle
styfle reviewed Oct 4, 2023
View reviewed changes
bin/main.js Outdated Show resolved Hide resolved
@styfle styfle changed the title Add --noclobber option to CLI feat: add --no-clobber option to CLI Oct 4, 2023
@UziTech UziTech merged commit b8adee7 into markedjs:master Oct 5, 2023
12 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 5, 2023
@semantic-release-bot
chore(release): 9.1.0 [skip ci]
7242d58 
# [9.1.0](v9.0.3...v9.1.0) (2023-10-05)

### Features

* add `--no-clobber` option to CLI ([#3025](#3025)) ([b8adee7](b8adee7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@UziTech UziTech UziTech approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

@joshbruce joshbruce Awaiting requested review from joshbruce

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it possible to add a noclobber option?
3 participants
@skoriop @UziTech @styfle