Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Rails dependency with only which Rails gems are actually needed #93

Closed
ssunday opened this issue Mar 25, 2021 · 2 comments
Closed

Comments

@ssunday
Copy link
Contributor

ssunday commented Mar 25, 2021

Instead of requiring rails can it be more specific and require just actionpack / activesupport for example? So it's not pulling in all of rails when that's not needed for this gem to work?

This has come up as an issue during the downstream issue regarding the marcel dependency (a dependency of activestorage) mimemagic. Even if we're not using activestorage, we cannot remove it as invisible_captcha depends on Rails in its entirety and pulls it in.

@markets
Copy link
Owner

markets commented Mar 25, 2021

Hello @ssunday 👋🏼

Yes! thanks for the ping, I also have followed the thread in Twitter and in the minad/mimemagic repo. Not really sure how it ended, but very interesting discussion. I have read a lot of interesting point of views there. Hopefully people will start using more and better caching deps in their CIs and deploys 😄 after that.

The change you are proposing seems very reasonable, even more since Rails is pulling new dependencies on each release and this gem only needs few parts of Rails to work 100% fine (we need Rails as dev dep, but yeah, not as runtime dep).

I'll try take a look asap, but I'm quite busy for at least ~2 weeks with other OSS work too. If someone wants to take a look and send a PR, I'd be happy to review it.

Best,
Marc

@ssunday
Copy link
Contributor Author

ssunday commented Mar 25, 2021

Thanks! I might raise a PR myself if/when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants