Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor compatibility updates #1

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Minor compatibility updates #1

merged 2 commits into from
Feb 24, 2023

Conversation

andrjohns
Copy link
Contributor

This PR makes some small fixes for rstan compatibility - namely specifying RcppParallel in the LinkingTo, and removing the src folder.

It's recommended that you don't commit/submit the src folder of your R package when using rstantools, so that it can be automatically generated at installation time. This allows your package to always be compatible with changes to the rstan and StanHeaders packages

Feel free to let me know if I can clarify anything here as well!

@marcogramatica marcogramatica merged commit 63531bb into marcogramatica:main Feb 24, 2023
@bgoodri
Copy link

bgoodri commented Mar 10, 2023

We need this merged PR to be released to CRAN in order to release the StanHeaders that has been years in the making but is still years behind the current Stan development branch. Please do so this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants