-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GitRemote version of the toolbar #8
Conversation
pom.xml
Outdated
<p> | ||
<img src="https://raw.github.com/markiewb/nb-git-toolbar/master/doc/screenshot1.gif"/> | ||
</p> | ||
|
||
<h2>Updates</h2> | ||
<h3>1.1.0:</h3> | ||
<h3>1.2.0:</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please append your changes. The changelog has to contain even the previous changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove the nbms. They are not necessary anymore. I will archive them using the github release feature.
@@ -69,5 +69,73 @@ | |||
<attr name="position" intvalue="900"/> | |||
</file> | |||
</folder> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you really sure that the toolbar is not visible, when I do not have a remote project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The GitRemote bar will only show up if C/C++ is enabled in netbeans. If C/C++ is not enabled, the GitRemote Toolbar icons wont show up.
When C/C++ is enabled, one can choose to enable/disable the Git Toolbar or the GitRemote toolbar accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to add some more precisions, the GitRemote actions becomes available in Netbeans as soon as C/C++ is activated. You dont need to have an active (open) remote C/C++ project for the bar to show up although the icons will be gray.
At that point, we need to have a look at issue #7 and try to hide the bars completly when a different or no versionning system is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. I will have another look and try tomorrow!
With kind regards, markiewb
2017-06-06 20:30 GMT+02:00 GG <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In src/main/resources/de/markiewb/netbeans/plugin/git/toolbar/layer.xml
<#8 (comment)>:
> @@ -69,5 +69,73 @@
<attr name="position" intvalue="900"/>
</file>
</folder>
+
Yes. The GitRemote bar will only show up if C/C++ is enabled in netbeans.
If C/C++ is not enabled, the GitRemote Toolbar icons wont show up.
When C/C++ is enabled, one can choose to enable/disable the Git Toolbar or
the GitRemote toolbar accordingly
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABxWRxIB1j0YBA1DBuOdHFOfEVUPfP78ks5sBZrGgaJpZM4Nxpf3>
.
|
I created a fork of the plugin. https://github.com/markiewb/nb-gitremote-toolbar |
This is for issue #6