Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitRemote version of the toolbar #8

Closed
wants to merge 3 commits into from

Conversation

ggqc007
Copy link

@ggqc007 ggqc007 commented Jun 6, 2017

This is for issue #6

pom.xml Outdated
<p>
<img src="https://raw.github.com/markiewb/nb-git-toolbar/master/doc/screenshot1.gif"/>
</p>

<h2>Updates</h2>
<h3>1.1.0:</h3>
<h3>1.2.0:</h3>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please append your changes. The changelog has to contain even the previous changes.

Copy link
Collaborator

@markiewb markiewb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the nbms. They are not necessary anymore. I will archive them using the github release feature.

@@ -69,5 +69,73 @@
<attr name="position" intvalue="900"/>
</file>
</folder>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you really sure that the toolbar is not visible, when I do not have a remote project?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The GitRemote bar will only show up if C/C++ is enabled in netbeans. If C/C++ is not enabled, the GitRemote Toolbar icons wont show up.

When C/C++ is enabled, one can choose to enable/disable the Git Toolbar or the GitRemote toolbar accordingly

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to add some more precisions, the GitRemote actions becomes available in Netbeans as soon as C/C++ is activated. You dont need to have an active (open) remote C/C++ project for the bar to show up although the icons will be gray.

At that point, we need to have a look at issue #7 and try to hide the bars completly when a different or no versionning system is used.

Copy link
Collaborator

@markiewb markiewb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markiewb
Copy link
Collaborator

markiewb commented Jun 6, 2017 via email

markiewb added a commit to ggqc007/nb-gitremote-toolbar that referenced this pull request Jun 10, 2017
@markiewb
Copy link
Collaborator

I created a fork of the plugin. https://github.com/markiewb/nb-gitremote-toolbar
Your code is integrated there. Thank you!

@markiewb markiewb closed this Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants