Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

setup.xqy fails to validate field range index config (most likely other range-indexes as well) #492

Closed
joemfb opened this issue Jul 8, 2015 · 6 comments
Closed

setup.xqy fails to validate field range index config (most likely other range-indexes as well) #492

joemfb opened this issue Jul 8, 2015 · 6 comments
Labels
bug deployer
Milestone
v1.7.5

Comments

@joemfb
Copy link
Contributor

joemfb commented Jul 8, 2015

Since setup.xqy uses the XML snippets from ml-config.xml directly, without validating their contents, it's possible to end up with a schema-invalid databases.xml configuration. Once that happens the REST Management API throws errors for database updates.

Specifically, I had a database with a range-field-index element containing a namespace-uri element (from the dmlc-healthcare project). This bootstraps (and works) without issue via Roxy. When I try to configure a database using the REST Management API (using ml-gradle and OBI), the PUT to /manage/v2/databases/obi-ui-content/properties fails with a 400 error.

This may properly be a bug of the Admin API not validating it's parameters. I'm not sure what an appropriate resolution would be, but wanted to capture the problem here.
@grtjn
Copy link
Contributor

grtjn commented Jul 8, 2015

I thought we fixed most of these cases. Which version of Roxy?

@joemfb
Copy link
Contributor Author

joemfb commented Jul 8, 2015

This was on v1.7.1, but the implementation is the same on current master: https://github.com/marklogic/roxy/blob/master/deploy/lib/xquery/setup.xqy#L2447

@grtjn
Copy link
Contributor

grtjn commented Jul 8, 2015

Ah yes, from the looks we forgot to fix path-index, and field-index. Will look asap..

@grtjn grtjn added this to the 1.7.3 milestone Jul 8, 2015
@grtjn grtjn self-assigned this Jul 8, 2015
@grtjn grtjn mentioned this issue Jul 21, 2015
Merged
@grtjn
Copy link
Contributor

grtjn commented Sep 22, 2015

Still applies..

@joemfb joemfb changed the title setup.xqy fails to valid field range index config (most likely other range-indexes as well) setup.xqy fails to validate field range index config (most likely other range-indexes as well) Feb 12, 2016
@grtjn
Copy link
Contributor

grtjn commented Mar 11, 2016

#499/#501 is related, but didn't fix this. Pushing away to allow release of 1.7.3 though..

@grtjn grtjn modified the milestones: 1.7.4, 1.7.3 Mar 11, 2016
@grtjn grtjn mentioned this issue Jun 3, 2016
Closed
@RobertSzkutak
Copy link
Contributor

Pushing off to the next release...

@RobertSzkutak RobertSzkutak modified the milestones: 1.7.5, 1.7.4 Oct 25, 2016
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 verify range-field-index spec before adding
fcde2f1
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 include invalid-values in field index spec fo…
696f1ae 
…r ML6+
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 range-field-index functions are present in al…
1ec835c 
…l supported ML versions
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 range-field-index functions exist for all sup…
f910182 
…ported ML versions
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 verify parameters for geospatial-element-indexes
abecd9b
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 verify parameters for geospatial-element-attr…
f8fa18d 
…ibute-pair indexes
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 verify parameters for geospatial-element-pair…
32f6f72 
…-indexes
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 verify parameters for geo-element-child-index…
aef0525 
…es, word lexicons
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 eliminated unnecessary recursion
e48c56b
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 forgot to ensure removal of existing fragment…
51ca346 
… roots
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 rewrote add-fragment-parents to avoid unneces…
b7c6ad3 
…sary recusion
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 fixing errors caught by self-test
4f74e8a
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 add-fields: eliminate unnecessary recursion a…
233dddc 
…nd eval
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 removed no-longer-needed eval; dropped suppor…
5ac5a7c 
…t for ML4
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 verify parameters and use xdmp:value instead …
3db0d31 
…of try/catch and eval for path-namespaces
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 verify range-path-index parameters
2acf1e8 
replace eval with xdmp:value
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 verify element-word-lexicon parameters
bd16710
dmcassel added a commit to dmcassel/roxy that referenced this issue Jan 17, 2017
@dmcassel
marklogic-community#492 verify parameters for phrase-throughs and -ar…
9f04575 
…ounds
RobertSzkutak added a commit that referenced this issue Jan 30, 2017
@RobertSzkutak
Merge pull request #719 from dmcassel/issue-492
ce2670b 
#492 verify parameters during setup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug deployer
Projects
None yet
Milestone
v1.7.5
Development

No branches or pull requests
3 participants
@grtjn @RobertSzkutak @joemfb