Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

The get-test-file/get-module-file test methods force returning unquoted documents. #638

Closed
rhdunn opened this issue Jul 27, 2016 · 1 comment

Comments

@rhdunn
Copy link
Contributor

rhdunn commented Jul 27, 2016

The helper:get-modules-file method called via helper:get-test-file has the following behviour:

  1. It loads the local files as text, then forces it through xdmp:unquote, hiding any errors (e.g. malformed XML).
  2. It forces text documents loaded from the modules database through xdmp:unquote, hiding any errors like with the local file code path.

This makes it difficult to load files in a specific format (XML documents as plain text, binary documents, etc.) for use in tests.

The swallowing of errors in xdmp:unquote hides potential issues, such as mismatched XML tags in an XML document, making it difficult to catch these errors when running the tests locally.

rhdunn pushed a commit to rhdunn/roxy that referenced this issue Jul 27, 2016
rhdunn pushed a commit to rhdunn/roxy that referenced this issue Jul 27, 2016
@dmcassel dmcassel added this to the 1.7.4 milestone Oct 18, 2016
@dmcassel
Copy link
Collaborator

fixed in dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants