Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moving STREAM_SOURCE_MAP to out.global in server side #14

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

bill-min
Copy link
Contributor

@bill-min bill-min commented Jan 3, 2023

Description

Having STREAM_SOURCE_MAP in module will cause issue when there is concurrency where the second request coming before the micro-frame-slot is reading STREAM_SOURCE_MAP. Also storing STREAM_SOURCE_MAP in module will make it persist in server and can cause memory issue.

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 89.66% // Head: 89.73% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (2e931c9) compared to base (577ecec).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   89.66%   89.73%   +0.06%     
==========================================
  Files          16       16              
  Lines         300      302       +2     
  Branches       67       68       +1     
==========================================
+ Hits          269      271       +2     
  Misses          9        9              
  Partials       22       22              
Impacted Files Coverage Δ
...c/components/micro-frame-slot/component/node.marko 91.66% <100.00%> (ø)
...onents/micro-frame-slot/component/web.component.ts 82.05% <100.00%> (ø)
...components/stream-source/component/StreamSource.ts 100.00% <100.00%> (ø)
src/components/stream-source/component/node.marko 95.65% <100.00%> (+0.41%) ⬆️
...omponents/stream-source/component/web.component.ts 90.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit fc36c57 into marko-js:main Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

🎉 This PR is included in version 1.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants