Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CsvDataReader.GetFieldSpan public. #120

Closed
anhaehne opened this issue Mar 30, 2022 · 3 comments
Closed

Make CsvDataReader.GetFieldSpan public. #120

anhaehne opened this issue Mar 30, 2022 · 3 comments

Comments

@anhaehne
Copy link

It would be great to be able to call CsvDataReader.GetFieldSpan directly to access the ReadOnlySpan<char>. My current usecase is to create hash for a single column and this way i could convert the ReadOnlySpan<char> to a ReadOnlySpan<byte> and pass that to my hash function.

Another use case would be to manually parse custom types.

@MarkPflug
Copy link
Owner

Sounds reasonable. I've quite nearly made it public in the past. The decision becomes whether to take a dependency on system.memory for netstandard2.0, or just not expose that API in ns2.0.

@anhaehne
Copy link
Author

Since GetRawRecordSpan is also just available for .ns2.1 and up i think the easiest would be to just make it public there.

@MarkPflug
Copy link
Owner

Pushed 1.1.13 to nuget which includes this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants