Set debug level for output

[thomseddon]

Firstly, just set out building my own asset compressor to find you had already done it! Another great CakePHP contribution, thanks Mark.

One quick question: I noticed that it seems the output is only passed through the filter at debug levels below 2, and this seems to be hard coded on this line?

I was running the shell on my development build (debug at 2) so couldn't actually pass the output through a filter?

I have attached a quick way I overrode it - sorry if I have just missed something.

Thanks again!

[markstory]

One reason the output filters don't run when debug = 2 is because running code through minifiers is generally not helpful in web requests when you're debugging. I agree though that running the shell even with debug = 2 should not disable any output filters.

I think another way to solve this could be to check if the current execution context is a console command, and then run the output filters regardless of the debug level.

[thomseddon]

Yeah, suppose that makes more sense, have pushed up something more towards that.

Not sure if there is a better way to detect if we are running shell, one option would be to directly check if we are using the cli SAPI with php_sapi_name(), but not sure if this is robust enough to fit all use cases? (although it wouldn't be breaking any kind of backwards compatibility if it didn't!?)

Haven't been to intimate with writing a Cake Shell before so there may be a better way to check from there, perhaps checking if the Shell class exists?

[markstory]

I think using php_sapi_name() == 'cli' is totally reasonable. I've not seen that screw up yet :)

[thomseddon]

Crackalackin, have just done that then

[markstory]

Awesome, thank you :D