Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sonar.search.javaAdditionalOpts #17

Closed
hdep opened this issue Dec 14, 2021 · 2 comments
Closed

Add support for sonar.search.javaAdditionalOpts #17

hdep opened this issue Dec 14, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hdep
Copy link

hdep commented Dec 14, 2021

Hello,

I'm looking to configured my sonarqube to mitigate the famous log4 vulnerability.
For this I need to set an option into sonar.properties according to :
https://community.sonarsource.com/t/sonarqube-sonarcloud-and-the-log4j-vulnerability/54721

I do not see in the puppet code a way to provide this option.
I tried to use sonar.search.javaOpts which is available in the module, but this breaks sonarqube.

Thank you for your feedback !

@fraenki
Copy link
Member

fraenki commented Dec 14, 2021

That's currently not easily possible. A new parameter needs to be introduced to allow passing arbitrary additional options to the sonar.properties.epp template.

The $config parameter might be a temporary workaround:
https://github.com/markt-de/puppet-sonarqube/blob/master/REFERENCE.md#config
However, this replaces the whole sonar.properties.epp template with the contents of this parameter, so you have to build the whole config from scratch (effectively eleminating most of the features of this module).

@fraenki fraenki added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 14, 2021
@hdep
Copy link
Author

hdep commented Apr 8, 2022

Hello,

I'll try to propose a PR for managing this parameter.

@fraenki fraenki closed this as completed Sep 20, 2022
@fraenki fraenki added enhancement New feature or request and removed help wanted Extra attention is needed labels Sep 20, 2022
@fraenki fraenki self-assigned this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants