Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for portable Windows binary #1065

Merged
merged 2 commits into from
Jun 5, 2019

Conversation

fxha
Copy link
Contributor

@fxha fxha commented Jun 4, 2019

Q A
BC breaks? yes
License MIT

Description

Removed the portable Windows package because of bad startup-time and other issues. The package was just added because we needed a non-admin package on Windows. Replaced by default setup that supports per-user installations too.

@fxha fxha added the 🛑 blocked This issue or PR is blocked by other issue label Jun 4, 2019
@fxha fxha self-assigned this Jun 4, 2019
@fxha fxha changed the title [WIP] Dropped support for portable Windows binary Drop support for portable Windows binary Jun 4, 2019
@fxha fxha removed the 🛑 blocked This issue or PR is blocked by other issue label Jun 4, 2019
@fxha fxha requested a review from Jocs June 4, 2019 19:15
@fxha fxha merged commit 4dada5b into marktext:develop Jun 5, 2019
@fxha fxha deleted the single-window-setup branch June 5, 2019 19:39
@yougotwill
Copy link

yougotwill commented Jun 6, 2019

@fxha @Jocs This binary was one of the reasons I used marktext over other markdown editors. I am unable to install marktext on my work computer and have to work from a portable flash drive. I assume the per user install wont work?

@fxha
Copy link
Contributor Author

fxha commented Jun 6, 2019

I think this isn't a problem because the portable executable was a compressed unpacker with both x86 and x64 7zip archives. Each time the binary is executed the archive is unpacked into temporary directory and Mark Text is executed and deleted when all windows are closed. If you launch the "new" setup without admin privileges you can choose to install per-user (non admin) or machine wide (admin privileges needed). The only difference is that the setup registers file extensions, all is done without admin privileges if you install per-user.

@yougotwill
Copy link

@fxha That seems fine. To confirm I can install marktext to a flash drive and have all the config stored on the flash drive itself?

@fxha
Copy link
Contributor Author

fxha commented Jun 7, 2019

I think so that you can install it on a flash drive. One big problem with the standalone Windows binary was that the configuration was always saved in the user data directory and we were unable to change it. As of upcoming v0.15.0, you can create a marktext-user-data directory in the application directory or pass --user-data-dir <path> to change the data directory. I still need to write documentation for this. Let's see, maybe I'll add portable zip packages for Window but we need an update check before, hosted somewhere or read from GitHub.

@yougotwill
Copy link

Amazing thank you for your consideration 🙏

Jocs pushed a commit that referenced this pull request Aug 7, 2019
* Dropped support for portable Windows binary

* Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants