Improvement: #414 Add functional bracket auto-completion #428
Conversation
|
Great thanks for this PR, I'll review it latter. |
|
@enyaxu I have one question： if you enter What's your opinions? I am very sorry that I reply to you now because I am busy recently. |
|
@jdoc sorry,I reply from my phone, I will comment later |
|
@enyaxu I can not see some characters in your above comment. |
|
@Jocs In Markdown world, use
|
|
@enyaxu There is a little bug. when I input |
|
@Jocs Ok, let me fix this. |
|
@Jocs Fix it, please review. |
|
I'll review it this evening. thanks. |
|
I found a problem, when I type |
| text = text.substring(0, offset) + text.substring(offset + 1) | ||
| this.cursor = lastCursor = { start, end } |
There was a problem hiding this comment.
This is because last implement used particalRender function, now yes It not needed.
| text = text.substring(0, offset) + text.substring(offset + 1) | ||
| } | ||
| } | ||
| block.text = text |
There was a problem hiding this comment.
the next 4 lines code need to put out of the if block. you can refer to the old codes.
|
@enyaxu I find the reason that caused the Chinese problem, and you can see the comments. |
|
@Jocs |
|
@enyaxu thank you again for this PR 👍 |
Description
Add functional bracket auto-completion for good experience.
Please Review.