Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ES6 / ES2015? #9

Closed
marcobiedermann opened this issue Feb 26, 2016 · 12 comments
Closed

Migrate to ES6 / ES2015? #9

marcobiedermann opened this issue Feb 26, 2016 · 12 comments

Comments

@marcobiedermann
Copy link

What do you think about migrating the project to ES2015?

@markusn
Copy link
Owner

markusn commented Mar 2, 2016

Hi! I am not familiar with the status of ES6 on nodejs, are there any benefits (especially in performance)?

@marcobiedermann
Copy link
Author

@markusn Using native ES2015 functions instead of your own will always be faster e.g. import vs require. Also with constthe interpreter can assign memory more efficiently.
With ES2015 you code might look cleaner for you and the parser to read.

@markusn
Copy link
Owner

markusn commented Mar 5, 2016

It seems interesting as it is possible to transpile to ES5 for backward compatibility for users of older versions of node. However I will not likely have time to implement this in the near future, but would happily take a pull-request.

@valmynd
Copy link

valmynd commented Nov 26, 2016

did a pull request, see #12

@evelynhathaway
Copy link
Contributor

@markusn, were you thinking of a build step and traspiling down to ES5? I'm down to help migrate to ES6+

@markusn
Copy link
Owner

markusn commented Mar 25, 2019

Hi! I'm going to do a 2.0.0 with ES6 (no transpiling to ES5).

@evelynhathaway
Copy link
Contributor

Awesome! Let me know if there's anything I can do to help. I've already changed var to let and const where appropriate in a fork (see commit: 5624aae) in case you want to rebase it or I can create a PR for it. 😄

@justinfagnani
Copy link

Any news here? I'd love to use this in a client-side JS modules only project. I can help port too.

@markusn
Copy link
Owner

markusn commented Feb 20, 2023

Any news here? I'd love to use this in a client-side JS modules only project. I can help port too.

Hi! What is stopping you from using it at the moment?

@justinfagnani
Copy link

justinfagnani commented Feb 20, 2023

@markusn browsers don't support Common JS, and I'm not using a bundler.

@markusn
Copy link
Owner

markusn commented May 30, 2023

@justinfagnani I have a PR open to solve this: #22 . Would that work for you?

@markusn
Copy link
Owner

markusn commented May 31, 2023

fixed in v1.4.0

@markusn markusn closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants