Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This add-on is really great, but I hope it can appear in the NVDA core. #3

Open
cary-rowen opened this issue Jul 25, 2021 · 4 comments

Comments

@cary-rowen
Copy link

Hello marlon-sousa

Yes, it seems that you opened a PR in the NVDA repo, but there has been no update recently. Can you continue to work?

sincere regards

@marlon-sousa
Copy link
Owner

Hello, Cary.

An issue is opened at NVDA repository. However, contributors asked to modify the code to reflect functionality that the addon does not provide, as it stand.

Mainly, they asked for a full merge strategy so that dictionaries from different profiles would merge ratter than the dictionary from the active profile being he only one responsible for generating substitutions.

This caused two things:

  • one is the fact that the code in this addon could not be fully transported to NVDA core, which means I would need time I didn't have at that time to integrate it. If they accepted this as it is fnow, we could have already integrated it (I would need no time at all because it is already built) and we could think in fiuture advancements latter.
  • I currently need that dictionaries from profiles are fully responsible for substitutions, as they are now. Making that modification would likely breaking my workflow. We could have reached a mode where the user could decide the merge strategy, but this would also need more coding.

This will clearly require more negotiation with contribuutors and more time from my part. While all this doesn't happen, the community can benefit from this addon the way it is now, specially with the recent compatibility with version 2021.1.

I appreciate though this request and will work on the PR as soon as I can.

However, it will still be in the hand of contributors the decision of integrating the PR on the NVDA code itself.

@cary-rowen
Copy link
Author

Hi, marlon,

I think I understand what you mean, and I must thank you for your work.
Another enhancement to the find dialog is also very good. I don't know what NVAccess is about. I think these are all functions that NVDA itself should have.

Wish you a happy new week

@cary-rowen
Copy link
Author

Hi,
My recent reliance on this add-on makes me again hope you'll open a PR to integrate it into the NVDA core.

@cary-rowen cary-rowen reopened this Jun 24, 2022
@marlon-sousa
Copy link
Owner

Hello Cary,

As much as you rely on it, so do I have a strong reliance, which prevented me from getting my own NVDA updated until I had time to port it to the new version.

As I said, the pr and issue are already opened, and it is stalled.

If you could please ask for more definitions from NVAccess on what they will decide on this feature, I would merge back this addon code into the NVDA source, but I have not the autonomy to do so by my self and have not heard from them in this regard.

I will let the pr link here so that you can follow it and then follow other associated issues: nvaccess/nvda#11005

Again, if you can lead on the debate and help to establish a plan I would be more than happy to colaborate.

Thanks,
Marlon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants