[RFR] Add optional selection column to list #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThieryMichel
commented
Mar 25, 2015
ThieryMichel
commented
ThieryMichel
force-pushed
the
multi_select_list
branch
from
c507d67
to
1362092
Compare
|
Is it now RFR? Can you update the screenshot? |
added 14 commits
March 31, 2015 09:41
ThieryMichel
force-pushed
the
multi_select_list
branch
from
399225d
to
09c119f
Compare
|
Don't display the action button if there are no selected items |
added 2 commits
March 31, 2015 17:27
ThieryMichel
force-pushed
the
multi_select_list
branch
from
0044045
to
684b0b8
Compare
| entityName = this.entity.name(); | ||
|
|
||
| this.DeleteQueries.batchDelete(this.view, this.entityIds).then(function () { | ||
| $location.path('/list/' + entityName); |
There was a problem hiding this comment.
use $state.go() instead, the url scheme may change in #376
Breaks the batchDelete page datagrid, to be fixed later
|
Saucelabs is drunk, tests are green on my side. I'm merging. Thanks for your work! |
fzaninotto
added a commit
that referenced
this pull request
Apr 1, 2015
[RFR] Add optional selection column to list
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.