-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Custom menu #376
[RFR] Custom menu #376
Conversation
Switching to RFR |
56b5e4a
to
27da2fd
Compare
@fzaninotto I'm certainly not the most qualified reviewer on es6 part, but for me everything is good. Especially as it is tested ... About that, all tests pass on local, but failed on travis. Is this a known issue ? |
Yes it is a known problem. e2e tests fail for no apparent reason, and it's a pain to debug. That's also why I didn't add more e2e tests for this PR. If you're satisfied with the code, I'll let you merge, and I'll push an update to the built files to master right after. |
Menu
modelEntity.menuView()
andMenu