Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Custom menu #376

Merged
merged 15 commits into from
Apr 3, 2015
Merged

[RFR] Custom menu #376

merged 15 commits into from
Apr 3, 2015

Conversation

fzaninotto
Copy link
Member

  • Add a Menu model
  • Add a compatibility layer between Entity.menuView() and Menu
  • Change all inner links to put the entity name first (e.f. '#/list/posts/' becomes '#/posts/list') (eases url recognition)
  • Optimize perf
  • write doc

image

@fzaninotto fzaninotto changed the title [WIP] Custom menu [RFR] Custom menu Apr 1, 2015
@fzaninotto
Copy link
Member Author

Switching to RFR

@alexisjanvier
Copy link
Contributor

@fzaninotto I'm certainly not the most qualified reviewer on es6 part, but for me everything is good. Especially as it is tested ... About that, all tests pass on local, but failed on travis. Is this a known issue ?

@fzaninotto
Copy link
Member Author

Yes it is a known problem. e2e tests fail for no apparent reason, and it's a pain to debug. That's also why I didn't add more e2e tests for this PR.

If you're satisfied with the code, I'll let you merge, and I'll push an update to the built files to master right after.

alexisjanvier added a commit that referenced this pull request Apr 3, 2015
@alexisjanvier alexisjanvier merged commit 1c38c45 into master Apr 3, 2015
@alexisjanvier alexisjanvier deleted the custom_menu_2 branch April 3, 2015 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants