[RFR] Introduce DataStore and remove entries for ReferenceField #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromemacias
changed the title
| @@ -17,7 +17,7 @@ define(function(require) { | |||
| } | |||
| function getWriteWidget() { | |||
| return '<ma-datagrid name="{{ field.getReferencedView().name() }}"' + | |||
| 'entries="field.entries" ' + | |||
| 'entries="::field.getReferencedView().getReferencesEntries()" ' + | |||
|
Could you add a checklist in the description to show what's left for RFR? |
jeromemacias
force-pushed
the
introducing_datastore
branch
3 times, most recently
from
9ff7886
to
ce1349c
Compare
…unctions to DataStore
jeromemacias
force-pushed
the
introducing_datastore
branch
from
ce1349c
to
7320cd2
Compare
jeromemacias
changed the title
| calls = [], | ||
| singleCallFilters, | ||
| identifiers, | ||
| reference, | ||
| referencedView, | ||
| entries, | ||
| datas, |
There was a problem hiding this comment.
data is already plural
manuquentin
added a commit
that referenced
this pull request
May 11, 2015
[RFR] Introduce DataStore and remove entries for ReferenceField
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View.entriespropertymapEntry(ies)from ViewRemove Views created by code for referencesResult of this refactoring:
RetrieveQueriesdoes not deal anymore withEntryDataStorenow store all entries, references and filter valuesmapEntryis now done byDataStorerouting.jsnow explicitly create and map entriesReferenceFielddoes not extendChoiceFieldanymore