[RFR] Do not deduplicate single choice remote complete fields #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .then(formattedResults => this._removeDuplicates(formattedResults, currentValue)); | ||
| .then(results => this._transformRecords(field, results)); | ||
|
|
||
| if (field.type() === 'reference_many') { |
jpetitcolas
force-pushed
the
remove_duplicate_multiple_only
branch
from
72d941d
to
af88689
Compare
|
Strange issue with tests:
Let's retry later. |
jpetitcolas
force-pushed
the
remove_duplicate_multiple_only
branch
from
af88689
to
cc7496d
Compare
fzaninotto
added a commit
that referenced
this pull request
Jul 23, 2015
[RFR] Do not deduplicate single choice remote complete fields
|
great! it worked well for me as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue found while debugging with @manuelnaranjo on [Gitter].
To prevent duplicates in multiple choices field, we remove already selected values from API responses. It works well for
reference_manyfields, but not forreferenceone. This PR disable deduplication for single choice fields.