Fixed backwards scope.choices test. Fixes #778. #779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ export default function maChoiceField($compile) { | |||
| refreshAttributes = 'refresh-delay="refreshDelay" refresh="refresh({ $search: $select.search })"'; | |||
| } | |||
|
|
|||
| var choices = scope.choices() ? scope.choices : (field.choices ? field.choices() : []); | |||
| var choices = scope.choices ? scope.choices() : (field.choices ? field.choices() : []); | |||
There was a problem hiding this comment.
nah, choices being passed to the directive with an &, it's always a function. So I guess the right fix should be
var choices = scope.choices() || (field.choices ? field.choices() : []);
|
Closing this, though the issue remains, as this PR is the wrong solution. I think the right solution might be (angular.isFunction(scope.choices) && scope.choices()) ? scope.choices : (field.choices ? field.choices() : []);I'm guessing that Angular is seeing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I couldn't test the code directly, because
make installwas erroring on me, and I don't have the time this second to dig into it.