Not following MUI's theme value name on Notification

[Seojun-Park]

Summary

<Notification /> uses MUI's <SnackBar /> component and overrides style according to type of notification(success, error, warning, undo...etc).

StyledSnackbar uses MUI's error palette on both case, error(error.dark) and warning(error.light).

• react-admin
  

  react-admin/packages/ra-ui-materialui/src/layout/Notification.tsx

  Lines 136 to 156 in be726d6

  	[`& .${NotificationClasses.success}`]: {
  	backgroundColor: theme.palette.success.main,
  	color: theme.palette.success.contrastText,
  	},
  	[`& .${NotificationClasses.error}`]: {
  	backgroundColor: theme.palette.error.dark,
  	color: theme.palette.error.contrastText,
  	},
  	[`& .${NotificationClasses.warning}`]: {
  	backgroundColor: theme.palette.error.light,
  	color: theme.palette.error.contrastText,
  	},
  	[`& .${NotificationClasses.undo}`]: {
  	color:
  	type === 'success'
  	? theme.palette.success.contrastText
  	: theme.palette.primary.light,
  	},

But, there is warning palette on MUI`'s default palette. (please refer the below screenshot, or link)

• MUI
  

Is there any reason that not using warning value from MUI's default palette?

[slax57]

Thanks for submitting this.
I don't think it's intended, so indeed it might be better to change the warning notification to use the 'warning' palette color.

Would you like to submit a PR to change this?

[Seojun-Park]

@slax57 Of course

I will make PR :)