Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: notifications with type 'warning' should use the warning color from the MUI palette #8519

Merged
merged 7 commits into from
Dec 20, 2022

Conversation

Seojun-Park
Copy link
Contributor

@Seojun-Park Seojun-Park commented Dec 19, 2022

Fixes #8510

@Seojun-Park
Copy link
Contributor Author

  • Warning

Screenshot 2022-12-19 at 14 09 13

- Error

Screenshot 2022-12-19 at 14 09 23

@antoinefricker antoinefricker added this to the 4.6.3 milestone Dec 19, 2022
@antoinefricker
Copy link
Contributor

Thanks for your contribution 👍
Could you rebase your PR on master as it fits for the next 4.6.3 release?

@Seojun-Park Seojun-Park changed the base branch from next to master December 19, 2022 13:48
@Seojun-Park Seojun-Park changed the base branch from master to next December 19, 2022 13:49
@Seojun-Park Seojun-Park changed the base branch from next to master December 19, 2022 13:50
@Seojun-Park Seojun-Park changed the base branch from master to next December 19, 2022 13:51
@Seojun-Park Seojun-Park changed the base branch from next to master December 19, 2022 13:53
@Seojun-Park Seojun-Park force-pushed the fix-notification-theme branch 2 times, most recently from e6f09f2 to ec02b1d Compare December 19, 2022 14:15
@vercel
Copy link

vercel bot commented Dec 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-admin 🔄 Building (Inspect) Dec 20, 2022 at 8:45AM (UTC)
react-admin-storybook 🔄 Building (Inspect) Dec 20, 2022 at 8:45AM (UTC)

@fzaninotto
Copy link
Member

You must also change all the error notifications that use the warning type, such as

notify('ra.notification.http_error', { type: 'warning' });

@Seojun-Park
Copy link
Contributor Author

You must also change all the error notifications that use the warning type, such as

notify('ra.notification.http_error', { type: 'warning' });

Changes

docs/useNotify.md Outdated Show resolved Hide resolved
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those changes!
Although there are still some type: 'warning' left at some places in the code.
I'll try to push them directly on your branch, and if I can't I'll provide a diff.

@Seojun-Park
Copy link
Contributor Author

@slax57

Thanks for those changes! Although there are still some type: 'warning' left at some places in the code. I'll try to push them directly on your branch, and if I can't I'll provide a diff.

Thank you!

@slax57 slax57 merged commit 66e0d78 into marmelab:master Dec 20, 2022
@slax57 slax57 changed the title fix(notification): follow notification palette theme Fix: notifications with type 'warning' should use the warning color from the MUI palette Dec 20, 2022
@slax57
Copy link
Contributor

slax57 commented Dec 20, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not following MUI's theme value name on Notification
4 participants