Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: notifications with type 'warning' should use the warning text color from the MUI palette #8532

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Fix: notifications with type 'warning' should use the warning text color from the MUI palette #8532

merged 1 commit into from
Dec 22, 2022

Conversation

Seojun-Park
Copy link
Contributor

@fzaninotto
Copy link
Member

Can you please add before / after screenshots?

@Seojun-Park
Copy link
Contributor Author

@fzaninotto

Oh sorry, I forgot to attach the screenshots.

  • Error

Screenshot 2022-12-22 at 14 16 13

  • Warning

Screenshot 2022-12-22 at 14 16 23

As you can see, there is no difference.
I also leave the documentation for contrastText : Screenshot 2022-12-22 at 14 16 23

@fzaninotto
Copy link
Member

Maybe there is a difference in dark mode ?

@Seojun-Park
Copy link
Contributor Author

@fzaninotto

in Darkmode

  • error.contrastText

Screenshot 2022-12-22 at 14 27 03

  • warning.contrastText

Screenshot 2022-12-22 at 14 27 13

@slax57 slax57 changed the title fix(notification): warning text color field Fix: notifications with type 'warning' should use the warning text color from the MUI palette Dec 22, 2022
fzaninotto
fzaninotto approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it's better in dark mode!

@fzaninotto fzaninotto merged commit 252f4b7 into marmelab:master Dec 22, 2022
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 4.6.3 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Seojun-Park @fzaninotto @slax57