-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password #23
Comments
I have the same problem. |
I've been looking into this and from what I can tell, its not protected with the given password. I've added a new unit test (which fails, as expected) to demonstrate this. In the test I create a zip archive with a password of "password". I then try and unzip this file with a password of "wrong-password" and look for any directories at the given location. To my surprise, the file has been unzipped. The branch can be found here: https://github.com/jwelton/Zip/tree/password-bug. I should mention, when attempting to open the zip by other means, the password "password" does not work. |
Do you mean there is a bug in minizip, the library, which you are using?
|
That's the same behaviour I'm seeing. I cant say for sure but the password is not null when being passed into minizip. Looks like the problem might be in minizip. |
I have the same problem as you and have solved it, please reference my above linked post. |
@dttrinh I have used the solution with enabling AES and it works - yes. One drawback is that unpacking still won't work with MacOS default unzip software. You need something like 7zip that supports compression method 99. Also it doesn't seem like a proper fix, rather a workaround for the existing problem. |
same. |
I've also got this problem. Create a zip file with a password on OSX. Can't unzip it because the password is rejected. I downloaded the aes folder from https://github.com/nmoinvaz/minizip and added it to the project (perhaps in the wrong way) and added #define HAVE_AES into zip.c - I am not sure what else to do. |
Same issue here. |
This is still an issue. According to the other thread, does minizip have to be fixed or configured properly in the master branch? |
Once zipped with password, can't unzip the file with the same password.
The text was updated successfully, but these errors were encountered: