Possible memory leak

[mcrakhman]

Hi!

I used you library to format phone numbers entered by user. And though I liked PhoneNumberKit a lot, I discovered certain memory leaks.

Please note that I updated the library to version 0.6.4 via cocoapods, just so you know that I am using the up-to-date version.

It seems both of the following lines cause memory leaks (thus if I delete both of them the leaks go away). Also PhoneNumber (rawNumber:) was tested in different apps with the same leaks.

do {
       _ = try PhoneNumber (rawNumber: phone!)
}
catch {
      isValidNumber = false
}

And this one:

let formattedString = PartialFormatter ().formatPartial (cutString)

cutString is a string starting with + and ending with numbers.

Below see instruments' screenshots.

[marmelroy]

Thanks @mcrakhman. Looks suspicious. I will investigate further this evening.

[marmelroy]

After some investigation - PhoneNumberKit keeps the parsed metadata in memory and a memory leak can, under certain circumstances, happen.

I've begun work on a significant change to PhoneNumberKit that will be a lot more explicit about ownership and will resolve these issues. It will also introduce some breaking changes to the API.

That work is on the https://github.com/marmelroy/PhoneNumberKit/tree/dev branch.

[marmelroy]

Good news!

I was able to resolve the memory leak issues without an API change. Bundling all the changes in release 0.7.

Thanks again for reporting these @mcrakhman.

[mcrakhman]

Thank you very much! Will update and try.