Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinDiff class dosn't pass accuracy to Diff class #23

Closed
mikeWShef opened this issue Feb 4, 2020 · 1 comment
Closed

FinDiff class dosn't pass accuracy to Diff class #23

mikeWShef opened this issue Feb 4, 2020 · 1 comment

Comments

@mikeWShef
Copy link

You can se the accuracy on instatiation of the FinDiff class and it is set as an attibute for the class but when Diff is called, this accuracy is not passed on:
lines 139, 141 and 151 of operators.py all read:
pd = Diff(axis, order)
Great package btw, really useful

@maroba
Copy link
Owner

maroba commented Jul 10, 2020

Sorry for the late reply!
The accuracy is not passed by the constructor but instead when applying the partial derivative, see operators.py lines 81 to 94. So it should be correct.
Glad, that you find it useful! :-)

@maroba maroba closed this as completed Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants