-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore using DatabasePreparer when creating a database for integration tests #81
Comments
Checked in a fix that gets us a cleaner solution (thanks @wslulciuc for the pointers). There is some more work we can do to make it even cleaner, but this will hopefully resolve the issue of intermittent test failures. |
Let's use JdbiRule instead to manage a Jdbi instance pointing to postgres. |
phixMe
pushed a commit
that referenced
this issue
Nov 12, 2020
Signed-off-by: Jill Hubley <jhubley@NYC-US09409-MBP.local> Co-authored-by: Jill Hubley <jhubley@NYC-US09409-MBP.local>
wslulciuc
pushed a commit
that referenced
this issue
Dec 3, 2020
bump version Signed-off-by: frankcash <frankcash@stockx.com>
wslulciuc
added a commit
that referenced
this issue
Dec 11, 2020
* Add marquez_airflow.version to job.context Signed-off-by: wslulciuc <willy@datakin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do we need our own
PreparedDbRule
? We're dynamically generating theconfig.yml
, which I'm not a fan of (and something I think we can hopefully avoid). Looking at the src for PreparedDbRule, on instantiation, it's creating the DB connection based on the details contained in DatabasePreparer. Worth exploring that as an option.The text was updated successfully, but these errors were encountered: