Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine failure recovery log and exception #2633

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

fyrestone
Copy link
Contributor

What do these changes do?

The logs and exceptions of failure recovery are not clear enough, this PR is to refine them.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this Jan 17, 2022
@fyrestone fyrestone marked this pull request as ready for review February 9, 2022 08:53
@fyrestone fyrestone changed the title [WIP] Refine failure recovery log and exception Refine failure recovery log and exception Feb 9, 2022
@fyrestone
Copy link
Contributor Author

fyrestone commented Feb 9, 2022

The vineyard CI fails because of AttributeError: module 'vineyard.data' has no attribute 'pickle'.

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi added this to In progress in Distributed via automation Feb 9, 2022
@wjsi wjsi added this to PR-In progress in v0.9 Release via automation Feb 9, 2022
@wjsi wjsi added this to the v0.9.0b1 milestone Feb 9, 2022
@wjsi wjsi merged commit 61c8eac into mars-project:master Feb 9, 2022
Distributed automation moved this from In progress to Done Feb 9, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done Feb 9, 2022
chaokunyang pushed a commit to chaokunyang/mars that referenced this pull request May 31, 2022
Merge branch cp_2633_2723_2730 of git@gitlab.alipay-inc.com:ray-project/mars.git into master
https://code.alipay.com/ray-project/mars/pull_requests/266

Signed-off-by: 不涸 <zhongchun.yzc@antgroup.com>


* Refine failure recovery log and exception (mars-project#2633)

* Refine fo log and exception

* Pin xgboost_ray to 0.1.5

Co-authored-by: 留宝 <po.lb@antgroup.com>
Co-authored-by: 刘宝 <po.lb@antfin.com>

* Fix duplicate exceptions in log (mars-project#2723)

* Add address and pid prefix to the mars exception message (mars-project#2730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Distributed
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants