Add address and pid prefix to the mars exception message #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjsi
reviewed
Feb 21, 2022
mars/oscar/backends/message.py
Outdated
| class _MarsError(ErrorMessage.AsCauseBase, type(self.error)): | ||
| pass | ||
|
|
||
| return _MarsError( |
There was a problem hiding this comment.
Wrapping existing errors has some side effects. For instance, some exception types have custom attributes, for instance, HTTP error codes. Wrapping with error messages hide these attributes and may lead to unexpected errors. Simply try adding attributes to these exceptions and log locations when handling exceptions at receiver end may be a better solution.
There was a problem hiding this comment.
Fixed. Thanks. I added a test case test_as_instanceof_cause for testing as_instanceof_cause.
wjsi
reviewed
Feb 21, 2022
mars/oscar/backends/pool.py
Outdated
| @@ -59,8 +59,9 @@ | |||
|
|
|||
|
|
|||
| class _ErrorProcessor: | |||
| def __init__(self, message_id: bytes, protocol): | |||
| def __init__(self, message_id: bytes, address: str, protocol): | |||
There was a problem hiding this comment.
Currently, the _ErrorProcessor needs some message info and the address of current pool. Replacing address to pool does not simplify the constructor parameters.
qinxuye
pushed a commit
to hekaisheng/mars
that referenced
this pull request
Mar 1, 2022
chaokunyang
pushed a commit
to chaokunyang/mars
that referenced
this pull request
May 31, 2022
…ars exception message (mars-project#2730) Merge branch improve_mars_exception_compatibility of git@gitlab.alipay-inc.com:ray-project/mars.git into master https://code.alipay.com/ray-project/mars/pull_requests/251 Signed-off-by: 慕白 <chaokun.yck@antgroup.com> * Add address and pid prefix to the mars exception message (mars-project#2730) * Fix CI
chaokunyang
pushed a commit
to chaokunyang/mars
that referenced
this pull request
May 31, 2022
Merge branch cp_2633_2723_2730 of git@gitlab.alipay-inc.com:ray-project/mars.git into master https://code.alipay.com/ray-project/mars/pull_requests/266 Signed-off-by: 不涸 <zhongchun.yzc@antgroup.com> * Refine failure recovery log and exception (mars-project#2633) * Refine fo log and exception * Pin xgboost_ray to 0.1.5 Co-authored-by: 留宝 <po.lb@antgroup.com> Co-authored-by: 刘宝 <po.lb@antfin.com> * Fix duplicate exceptions in log (mars-project#2723) * Add address and pid prefix to the mars exception message (mars-project#2730)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Developers need the address and pid for debug in a large distributed cluster, so this PR,
An example exception,
Related issue number
Fixes #xxxx
Check code requirements