Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate exceptions in log #2723

Merged
merged 5 commits into from
Feb 21, 2022
Merged

Fix duplicate exceptions in log #2723

merged 5 commits into from
Feb 21, 2022

Conversation

fyrestone
Copy link
Contributor

What do these changes do?

Fix duplicate exceptions in log.

Related issue number

Fixes #2722

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye qinxuye added type: enhancement request mod: client to be backported Indicate that the PR need to be backported to stable branch labels Feb 19, 2022
@qinxuye qinxuye added this to In progress in Misc via automation Feb 19, 2022
@qinxuye qinxuye added this to PR-In progress in v0.9 Release via automation Feb 19, 2022
@qinxuye qinxuye added this to the v0.9.0b2 milestone Feb 19, 2022
@qinxuye qinxuye modified the milestones: v0.9.0b2, v0.9.0b1 Feb 21, 2022
@qinxuye
Copy link
Collaborator

qinxuye commented Feb 21, 2022

Codacy check failed: https://app.codacy.com/gh/mars-project/mars/pullRequest?prid=8912995

@qinxuye
Copy link
Collaborator

qinxuye commented Feb 21, 2022 •
edited
Loading

Vineyard test A few tests failed, looks like it's related, could you please take a look?

@fyrestone
Copy link
Contributor Author

fyrestone commented Feb 21, 2022 •
edited
Loading

Vineyard test A few tests failed, looks like it's related, could you please take a look?

Thanks. I am fixing the CI, some errors are caused by No module named 'tqdm'.

@fyrestone
Copy link
Contributor Author

Vineyard test A few tests failed, looks like it's related, could you please take a look?

Thanks. I am fixing the CI, some errors are caused by No module named 'tqdm'.

wjsi
wjsi reviewed Feb 21, 2022
View reviewed changes
mars/deploy/oscar/session.py Outdated Show resolved Hide resolved
qinxuye
qinxuye approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi
wjsi approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Misc automation moved this from In progress to Reviewer approved Feb 21, 2022
@wjsi wjsi merged commit b747a42 into mars-project:master Feb 21, 2022
Misc automation moved this from Reviewer approved to Done Feb 21, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done Feb 21, 2022
wjsi pushed a commit to wjsi/mars that referenced this pull request Feb 21, 2022
@fyrestone @wjsi
Fix duplicate exceptions in log (mars-project#2723)
6e2ecab
@wjsi wjsi mentioned this pull request Feb 21, 2022
Merged
hekaisheng pushed a commit that referenced this pull request Feb 21, 2022
@wjsi @fyrestone
[BACKPORT]Fix duplicate exceptions in log (#2723) (#2736)
da6631e 
Co-authored-by: Liu Bao <fyrestone@outlook.com>
@hekaisheng hekaisheng added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Feb 21, 2022
qinxuye pushed a commit to hekaisheng/mars that referenced this pull request Mar 1, 2022
@fyrestone
Fix duplicate exceptions in log (mars-project#2723)
65ee7d8
chaokunyang pushed a commit to chaokunyang/mars that referenced this pull request May 31, 2022
PullRequest: 266 [CP from github] 2633 2723 2730
e4838c3 
Merge branch cp_2633_2723_2730 of git@gitlab.alipay-inc.com:ray-project/mars.git into master
https://code.alipay.com/ray-project/mars/pull_requests/266

Signed-off-by: 不涸 <zhongchun.yzc@antgroup.com>


* Refine failure recovery log and exception (mars-project#2633)

* Refine fo log and exception

* Pin xgboost_ray to 0.1.5

Co-authored-by: 留宝 <po.lb@antgroup.com>
Co-authored-by: 刘宝 <po.lb@antfin.com>

* Fix duplicate exceptions in log (mars-project#2723)

* Add address and pid prefix to the mars exception message (mars-project#2730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng left review comments

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: client type: enhancement request
Projects
Misc
  
Done
v0.9 Release
PR-Done
Milestone
v0.9.0b1
Development

Successfully merging this pull request may close these issues.

[BUG] Duplicate exceptions in log
4 participants
@fyrestone @qinxuye @wjsi @hekaisheng