Add load_only and dump_only options #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -290,6 +294,8 @@ def deserialize(self, data, fields_dict, many=False, validators=None, | |||
| exception_class=UnmarshallingError, | |||
| strict=strict | |||
| ) | |||
| if field_obj.dump_only: | |||
There was a problem hiding this comment.
This should go before the call to _call_and_store. If the field dump-only, no need to do the work of deserializing the value and validating it.
|
Thanks! Just a minor change to make. Once the tests and docs are added, this is good to merge. |
|
Done. |
| if (value is missing) or (skip_missing and | ||
| value in field_obj.SKIPPABLE_VALUES): | ||
| skip_conds = ( | ||
| field_obj.load_only, |
There was a problem hiding this comment.
Actually, we can check field_obj.load_only before running _call_and_store as well.
|
Thanks for adding tests and docs. Just one last change and this is good to merge. |
|
Uhm, no, we can't. This test is going to fail: https://github.com/marshmallow-code/marshmallow/blob/dev/tests/test_schema.py#L362 This is the reason why I initially put them both after _call_and_store. |
|
OK. I see. Thanks |
This was referenced Jan 25, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstrings and unit tests are still missing. Let me know if these changes are ok and I'll add them.