-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First CLASS validators #89
Conversation
The unit tests for all of the class-based validators are in the commit above. |
Thank you for your contribution. This PR contains unrelated changes. Can you please separate this into 3 PRs?
Once those are sent, I'd be glad to review them! |
@sloria if it's not a problem for you I'd prefer to keep them in a single pr. it's more easy for me and the same for you. these unrelated changes are all in different files. you should not have any problem in reviewing them separately. thank you |
I would much prefer to review them as separate PRs. Having the separate branches not only helps mergeability, but also adds useful historical information to the commit log. Since the changes are in separate files, it should be straightforward to do:
|
Ok. I'll open the PRs. Just a few minutes. |
I'd appreciate an early code review. Then I'll write the unit tests. Spotted and fixed a bug in the email validator. Added Function and NoneOf validators. With these two I consider the validate module complete and ready for battle!