Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send report instead of deleting submisions #7

Closed
martijnboers opened this issue Feb 4, 2020 · 2 comments · Fixed by #10
Closed

Send report instead of deleting submisions #7

martijnboers opened this issue Feb 4, 2020 · 2 comments · Fixed by #10
Labels
enhancement New feature or request
Milestone
Beta Launch

Comments

@martijnboers
Copy link
Owner

martijnboers commented Feb 4, 2020 •
edited
Loading

A requirement to test the bot is that as a first step it should send modmail instead of deleting submissions when they exceed the threshold.

Should it also not reply with the artist bio?
@martijnboers martijnboers added the enhancement New feature or request label Feb 4, 2020
@martijnboers martijnboers added this to the Beta Launch milestone Feb 4, 2020
@martijnboers martijnboers changed the title Send modmail instead of deleting subbmisions Send modmail instead of deleting submisions Feb 4, 2020
@Nedlinin
Copy link
Collaborator

Nedlinin commented Feb 4, 2020

To clarify, instead of sending mod mail it can simply report the post with a reason similar to "BlotterTrax suggests a mod check out this point for exceeding limits. : "

@Nedlinin
Copy link
Collaborator

Nedlinin commented Feb 4, 2020

wrt; bio, I think go ahead and post it though I think we need to ensure it only gets stickied if we actually found an artist.

@Nedlinin Nedlinin changed the title Send modmail instead of deleting submisions Send reporting instead of deleting submisions Feb 5, 2020
@Nedlinin Nedlinin changed the title Send reporting instead of deleting submisions Send report instead of deleting submisions Feb 5, 2020
Nedlinin added a commit that referenced this issue Feb 17, 2020
@Nedlinin
Added REMOVE_SUBMISSIONS flag to allow us to toggle between reporting…
dada70b 
… a post and removing it. This currently is set on the config level globally but at some point we probably want to determine this dynamically based on the type of error (for instance, a feature is in "beta").

Changed verb from "archive" to "remove" in function names to more closely reflect the nomenclature of reddit.

Fixes #7.
@Nedlinin Nedlinin mentioned this issue Feb 17, 2020
Merged
martijnboers added a commit that referenced this issue Feb 19, 2020
@Nedlinin @martijnboers
Added REMOVE_SUBMISSIONS flag (#10)
1331c76 
* Added REMOVE_SUBMISSIONS flag to allow us to toggle between reporting a post and removing it.  This currently is set on the config level globally but at some point we probably want to determine this dynamically based on the type of error (for instance, a feature is in "beta").

Changed verb from "archive" to "remove" in function names to more closely reflect the nomenclature of reddit.

Fixes #7.

* Fix python formatting issues.

* Fix issue with undefined var.

* Hopefully fix last scoping issue! :)

* Ensure new flag gets loaded into Config class properly.

* Fix formatting

* Remove the double URL parsing.

Fix bad member reference in remove_submission_exceeding_threshold.

Add in a few comments to better section code.

Co-authored-by: Martijn Boers <2955898+martijnboers@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Beta Launch
Development

Successfully merging a pull request may close this issue.

Added REMOVE_SUBMISSIONS flag martijnboers/BlotterTrax
2 participants
@Nedlinin @martijnboers