Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Inline chords #30

Closed
artutra opened this issue Oct 19, 2017 · 5 comments
Closed

[Feature request] Inline chords #30

artutra opened this issue Oct 19, 2017 · 5 comments

Comments

@artutra
Copy link

artutra commented Oct 19, 2017

What about a inline chord notation? Like:

Intro: [[C]] [[Am]]
[C]Som[G]e random lyrics

So it will be rendered this way:

Intro: C Am
C G
Some random lyrics

@martijnversluis
Copy link
Owner

martijnversluis commented Oct 19, 2017

@artutra Thanks for your feedback!

Would you know any library or software that currently supports that "double bracket" notation?

Currently, you could accomplish the same by also putting the text inside brackets:

[Intro: ][C] [Am]
[C]Som[G]e random lyrics

@artutra
Copy link
Author

artutra commented Oct 20, 2017

Thanks for the quick response!
Sorry, I dont know of any library that supports this notation. It's just a suggestion that I think would make the notation more customizable.
I made a simple website for guitar tabs once (which already shut down) and there were many tabs with chords in line. So i had to make this little modification in chordpro notation.
And with [Intro: ][C] [Am] it would render an unnecessary blank line

@martijnversluis
Copy link
Owner

My goal for this library is to stick to the ChordPro specs. You are right though in saying a line having only chords (content between [ ] ) should not have a blank line below it, unless the blank line exists in the ChordPro source.

I'm going to add it to the project board and will probably release a patch for it soon.

Thanks again for your feedback!

@martijnversluis
Copy link
Owner

@artutra I fixed the "extra blank line" issue. I released patch version 1.5.3. I also updated ChordFiddle to use this version.

@artutra
Copy link
Author

artutra commented Oct 23, 2017

Thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants