Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method from_impact_template() #118

Merged
merged 7 commits into from
Jan 12, 2021
Merged

Method from_impact_template() #118

merged 7 commits into from
Jan 12, 2021

Conversation

laumalo
Copy link
Collaborator

@laumalo laumalo commented Jan 8, 2021 •
edited
Loading

@laumalo laumalo changed the title Impact parser Method from_impact_tempalte() Jan 8, 2021
@laumalo laumalo linked an issue Jan 8, 2021 that may be closed by this pull request
Load parameters from an Impact file #93
Closed
@lgtm-com
Copy link

lgtm-com bot commented Jan 8, 2021

This pull request introduces 1 alert when merging f23f003 into 549a6c3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Jan 8, 2021

This pull request introduces 1 alert when merging 858e79c into 549a6c3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Jan 8, 2021

This pull request introduces 1 alert when merging 3ea8c35 into 549a6c3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@codecov-io
Copy link

codecov-io commented Jan 8, 2021 •
edited
Loading

Codecov Report

Merging #118 (bbffd11) into devel (eb02cd7) will increase coverage by 0.57%.
The diff coverage is 100.00%.

@laumalo laumalo changed the title Method from_impact_tempalte() Method from_impact_template() Jan 8, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jan 8, 2021

This pull request introduces 1 alert when merging bbffd11 into 549a6c3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

martimunicoy
martimunicoy approved these changes Jan 12, 2021
View reviewed changes
Copy link
Owner

@martimunicoy martimunicoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!:)

@laumalo laumalo merged commit 361ec22 into devel Jan 12, 2021
@laumalo laumalo deleted the impact_parser branch January 12, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martimunicoy martimunicoy martimunicoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load parameters from an Impact file
3 participants
@laumalo @codecov-io @martimunicoy