Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: why not translate in the rendering engine #13

Closed
jcalfee opened this issue Nov 13, 2015 · 4 comments
Closed

Question: why not translate in the rendering engine #13

jcalfee opened this issue Nov 13, 2015 · 4 comments

Comments

@jcalfee
Copy link

jcalfee commented Nov 13, 2015

Seems like one could apply translations in react's DOM patch before it hits the real DOM. A simple set of regular expressions would take most of the translations out of the code and move it into the external translation resources. This seems more consistent with modern localization software in my experience.

Please comment... Thank you.

@martinandert
Copy link
Owner

@jcalfee Sorry but I don't get it. Could you give me an example (a gist) of what you're trying to achieve?

Thanks

@martinandert
Copy link
Owner

Closing because of staleness.

@jcalfee
Copy link
Author

jcalfee commented Jun 13, 2016

I'm just suggesting to not have translations in the code and instead move it to the dom rendering layer. This will save a ton of effort on the part of the coders. In react this needs to happen in a way so that reacts DOM comparison is always translating then comparing to the translated DOM. You can still put translations in the code, most of the tedious translation work will not be needed anymore.

@jcalfee
Copy link
Author

jcalfee commented Jun 13, 2016

I apologize, I missed your first comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants