Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated UID handling #13

Closed
mike-matera opened this issue Nov 18, 2014 · 5 comments
Closed

Updated UID handling #13

mike-matera opened this issue Nov 18, 2014 · 5 comments

Comments

@mike-matera
Copy link

Hi Javier,

I've created a pull request that fixes some compile issues with the scull driver. I may fix others if I have time before class!

Cheers
./m

@bodgergely
Copy link

current_uid().val
current_euid().val
to all instances!

@bodgergely
Copy link

it compiles cleanly after that

@mike-matera
Copy link
Author

Hi bodgergely.. That does work but I don't think it's the right thing to do. I used the functions defined in the kernel (uid_eq() and such) to compare uids. Using those guards against future changes to the kuid structures.

The changes are shown in my pull request.

@bodgergely
Copy link

Yeah, you are right about not relying on the internals directly. Thanks I will use that function instead.

@martinezjavier
Copy link
Owner

I'm closing this because it was already fixed by commit 0a7ee7d ("Fix failure to compile the scull.").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants