Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chinese Holiday Support #70

Open
realZhangChi opened this issue Sep 7, 2022 · 1 comment
Open

Chinese Holiday Support #70

realZhangChi opened this issue Sep 7, 2022 · 1 comment

Comments

@realZhangChi
Copy link

realZhangChi commented Sep 7, 2022 •
edited
Loading

Hi,
Could you support chinese holiday?
Thanks!
@martinjw
Copy link
Owner

martinjw commented Sep 7, 2022

It would need to calculate lunisolar months (for Chinese New Year, Dragon Boat festval) - the .net ChineseLunarsolarCalendar class should provide the information.

As far as I can see, each year is only announced 3 weeks in advance by the General Office of the State Council. Calculating it may risk errors.

The week-swapping rules are challenging. It's not just weekend holidays being shifted into the week; nearby weekends become working days. So for 2022, National Day (3 day holiday) is 7 days from 1st October to 7th October, but Saturday 8th and Sunday 9th October are working days.

It may be possible to calculate, but it can't guarantee being accurate because each year must be officially determined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinjw @realZhangChi