Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One off 'Day of Mourning' for QEII #71

Closed
seancallinan opened this issue Sep 12, 2022 · 2 comments
Closed

One off 'Day of Mourning' for QEII #71

seancallinan opened this issue Sep 12, 2022 · 2 comments

Comments

@seancallinan
Copy link
Contributor

Commonwealth countries including the UK, Australia, Canada and New Zealand have announced a one-off 'Day of Mourning' in recognition of the death of Queen Elizabeth II, either falling on the day of her funeral in the UK (19th September 2022) or a day shortly thereafter (22 Sep for Australia, 26 Sep for NZ).

Would it be worth submitting a PR to include these one-off public holidays to allow for users of the library to recognise that these dates are in fact public holidays, or because it's only a one-off in the very near future (and people might not update their libraries quick enough) is it not worth it?

@martinjw
Copy link
Owner

Already done and released for UK. Yes, Ca+Au+NZ need updating.

The official name for UK and Canada, announced last Friday, is "State Funeral of Queen Elizabeth II", but a quick check shows the name in Au + NZ is National Day of Mourning.

There is likely to be another one off bank holiday for the coronation of Charles III, at least in the UK, but no date is announced yet and it may even be next year,

@martinjw
Copy link
Owner

Released as 2.16.2 on nuget. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants