Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Australia - Handling King vs Queen birthday #84

Closed
dotnetshadow opened this issue Feb 8, 2023 · 4 comments
Closed

Australia - Handling King vs Queen birthday #84

dotnetshadow opened this issue Feb 8, 2023 · 4 comments

Comments

@dotnetshadow
Copy link

Hi there,

Just wondering if there is any consideration given to naming of King vs Queens birthday?
@martinjw
Copy link
Owner

martinjw commented Feb 8, 2023

  • Also New Zealand.
  • Also technically Canada, but it is named Victoria Day (thanks Canada for not keeping up to date)

Perhaps MonachsDay or SovereignDay? Or just change to KingsDay? Or dynamically change the holiday name (year>=2023? "KingsDay" : "QueensDay" )?

Any preferences?

@dotnetshadow
Copy link
Author

I like the idea of MonachsDay but perhaps allow for the name to change every time there is a new King/Queen?
i.e. "Queen's Birthday" | "King's Birthday" but associate the enum to MonachsDay?

martinjw added a commit that referenced this issue Feb 9, 2023
@martinjw
#84 Australia+New Zealand add King's Birthday (overload of Queen's Bi…
a2e73f2 
…rthday)
@martinjw
Copy link
Owner

https://github.com/martinjw/Holiday/releases/tag/2.26.0.0

@dotnetshadow
Copy link
Author

Hi there,

I just had a chance to try the library out with the new "king" support but I don't know if it's working

I seem to get only Queens Birthday as the name, am I doing something wrong?
image

@dotnetshadow dotnetshadow mentioned this issue Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dotnetshadow @martinjw