Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates that aren't public holidays in DenmarkPublicHoliday #89

Closed
msboeg opened this issue Mar 16, 2023 · 1 comment
Closed

Dates that aren't public holidays in DenmarkPublicHoliday #89

msboeg opened this issue Mar 16, 2023 · 1 comment

Comments

@msboeg
Copy link
Contributor

msboeg commented Mar 16, 2023

Hello!

I've recently been looking into using this package for determining bank closing days in Scandinavia, but noticed that Denmark is wrong.
Constitution Day and Labour Day are not public holidays in Denmark, but are days off as part of agreement between unions and employers - and very often mutually exclusive.

I would personally remove both days from the class, but this isn't backwards compatible, so I'd like to know how you'd like this change to be made, before I start implementing it (or if you'll do it yourself).

Thanks 😊

@martinjw
Copy link
Owner

Maybe a boolean property or properties- IncludeConstitutionDay? And/or a boolean passed into a non-default constructor? (and a default constructor will include the dates, for compatibility)

In some countries some holidays are regional, and we pass in the region into the constructor, with HasHoliday() properties used with this. It's not quite the same pattern - I imagine it's sector/company specific, but it's similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants