Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight search keyword in result messages #63

Closed
blackarcher21 opened this issue Sep 18, 2016 · 9 comments
Closed

Highlight search keyword in result messages #63

blackarcher21 opened this issue Sep 18, 2016 · 9 comments
Assignees
Labels
Component-Message-List Component-Web-Browser Status-Fixed Ticket is resolved. Type-Enhancement This is request for brand new feature.
Milestone

Comments

@blackarcher21
Copy link

I can't find any way for this, so I would like to make a request. I think it will help to find where a certain words appear in messages, especially messages with lots of content. Whether it will be optional or by default, that would be your decision. :)

@martinrotter martinrotter self-assigned this Sep 19, 2016
@martinrotter
Copy link
Owner

You can filter messages with top/right textbox which should filter via all columns. But I guess that you want to add standard CTRL+F searching/highlighting in single selected message right? Does this concern webengine message display mode or simple text message display mode?

@blackarcher21
Copy link
Author

I guess that you want to add standard CTRL+F searching/highlighting in single selected message right?
Yes. When read on filtered message, keywords are highlighted in every messages in preview (if possible).
Does this concern webengine message display mode or simple text message display mode?
I only use and test with simple text message display which doesn't have it. Which one should/possible to have it, maybe you know more about it. I hope it possible for both though.

@martinrotter
Copy link
Owner

Yes. When read on filtered message, keywords are highlighted in every messages in preview (if possible).

To understand you. I understand this that you want to highlight searched words with ONE message? Is that correct? You can filter all messages in message list already, that feature is there.

@blackarcher21
Copy link
Author

I don't see any highlight in message I preview.
What I do:

  • Enter keyword in search box
  • Select a message from filtered to show it in preview
  • Looking for message content, no words are highlighted.
    OK, I test with current version I use v3.3.5 nowebengine, and previous version I saved, v3.3.4
    Am I wrong? Sorry if there's a misunderstanding here

@martinrotter
Copy link
Owner

Yes yes, you get it right. The search box is meant to show only messages which contain entered keyword, the keyword itself is not highlighted in any way in those messages.

I will add probably CTRL+F shortcut and implement "find dialog" for webengine and maybe for no-webengine too, if possible.

@martinrotter martinrotter added this to the 3.3.6 milestone Sep 22, 2016
@martinrotter
Copy link
Owner

EDIT: I made research, it is possible to add "find/highlight" for both message frontends.

@martinrotter
Copy link
Owner

BTW: I tweaked my auto-build scripts and no-webengine version of RSS Guard is now automatically compiled from EACH commit.

https://github.com/martinrotter/rssguard/wiki/Windows-development-builds

@blackarcher21
Copy link
Author

Thanks for the notification :)

@martinrotter martinrotter modified the milestones: 3.4.0, 3.3.6 Dec 21, 2016
@martinrotter martinrotter modified the milestones: 4.0.0, 3.4.0 Feb 8, 2017
@martinrotter martinrotter removed this from the 4.0.0 milestone Mar 13, 2017
@martinrotter martinrotter added this to the 3.5.5 milestone Oct 25, 2017
@martinrotter martinrotter added the Status-Fixed Ticket is resolved. label Oct 25, 2017
@martinrotter
Copy link
Owner

Fixed, see changelog on how to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Message-List Component-Web-Browser Status-Fixed Ticket is resolved. Type-Enhancement This is request for brand new feature.
Projects
None yet
Development

No branches or pull requests

2 participants