Integrate mpris #93

martpie · 2016-06-30T10:01:03Z

Basically:

Edit: 11/09/18

Things to think about:

Possibly native dependencies (would complicate the build system)
Apparently not working everywhere
https://www.npmjs.com/package/mpris-service
https://www.npmjs.com/package/mpris

YurySolovyov · 2016-08-12T09:32:02Z

Found mpris-service, but it seems like it uses native deps.
There is also node-dbus in pure JS. Might worth doing a fork or something

vprigent · 2016-09-12T17:22:32Z

Could better system integration also include notifications and computer specific shortcuts for play/pause ?

Notifications could be a whole new issue though ...

YurySolovyov · 2016-09-12T17:25:49Z

@vprigent what kind of info do you expect to see in notifications?

vprigent · 2016-09-12T17:36:29Z

Which music in currently playing

Depending on the notification system, you can probably include prev/next buttons
I don't see that as a top priority. As a user, i would be more interested in interacting with the software without the need to switch to the program.

martpie · 2016-09-12T18:32:15Z

@vprigent so when a track changes, add a native notification ? Seems fair to me.

About prev/next buttons, they are present on Windows, the Ubuntu integration is in progress but it's kind of complicated, and the native key for next/prev/play on Mac should work fine in the next release.

vprigent · 2016-09-12T21:30:45Z

@KeitIG Yup ! I've seen that kind in Rhythmbox ( Linux app )
I need to test the app on Windows ! Currently linux fan ..

mhanoglu · 2017-04-07T20:43:41Z

And sometimes Fn+F11 / Fn+F12 key combinations for prev & next song not working..
Thanks for program.

OS: ElementaryOS 0.4 ( Ubuntu 16.04 )

martpie · 2017-04-07T21:52:49Z

@marzochi Playback keyboard shortcuts "should" be supported, even if I could not test it personally (all laptops have different shortcuts for these). Can you send us the model of your laptop?

mhanoglu · 2017-04-08T07:47:12Z

Thanks for reply.

description: Laptop
product: IdeaPad Z580 (System SKUNumber)
vendor: LENOVO
version: Lenovo Z580
elementary OS 0.4 Loki (64-bit)
Built on "Ubuntu 16.04.2 LTS"

martpie · 2018-02-06T13:07:38Z

So I war re-reading http://www.omgubuntu.co.uk/2017/09/will-you-miss-gnome-legacy-tray again to understand why Gnome wanted Trays to disappear.

The explanation is basically: don't use Trays when you can use MPRIS.

Reminder:

martpie · 2018-02-06T13:57:17Z

Apparently https://getharmony.xyz managed to do it

martpie · 2018-04-04T12:57:57Z

Let's just steal this: https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/search?utf8=%E2%9C%93&q=mpris&type=

YurySolovyov · 2019-02-21T18:07:07Z

node-dbus-next (pure JS) has MPRIS media player example that might be of use.

igorer88 · 2019-03-01T23:58:28Z

Working on it ;)

martpie · 2019-03-13T16:16:40Z

with mpris-service@2.0.0 elementary os (Ubuntu 18.04) stack trace


> museeks@0.10.1 museeks /home/pierre/dev/museeks
> electron .

(node:4575) UnhandledPromiseRejectionWarning: Error: unknown bus address
    at createStream (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/dbus-next/index.js:22:1)
    at createConnection (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/dbus-next/index.js:76:1)
    at Object../node_modules/dbus-next/index.js.module.exports.createClient (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/dbus-next/index.js:136:1)
    at Object../node_modules/dbus-next/index.js.module.exports.sessionBus (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/dbus-next/index.js:149:1)
    at Player../node_modules/mpris-service/dist/index.js.Player.init (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/mpris-service/dist/index.js:105:1)
    at new Player (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/mpris-service/dist/index.js:97:1)
    at Player (/home/pierre/dev/museeks/dist/main/webpack:/node_modules/mpris-service/dist/index.js:90:1)
    at new MprisModule (/home/pierre/dev/museeks/dist/main/webpack:/src/main/modules/mpris.ts:14:12)
    at /home/pierre/dev/museeks/dist/main/webpack:/src/main/main.ts:124:5
    at step (/home/pierre/dev/museeks/dist/main/bundle.js:62402:23)
(node:4575) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:4575) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Ubuntu 18.10:

➜  museeks git:(mpris) npm run museeks

> museeks@0.10.1 museeks /home/pierre/Documents/museeks
> electron .

(node:3444) UnhandledPromiseRejectionWarning: Error: unknown bus address
    at /home/pierre/Documents/museeks/dist/main/bundle.js:13:4223
    at createConnection (/home/pierre/Documents/museeks/dist/main/bundle.js:13:5336)
    at Object.module.exports.createClient (/home/pierre/Documents/museeks/dist/main/bundle.js:13:6211)
    at Object.module.exports.sessionBus (/home/pierre/Documents/museeks/dist/main/bundle.js:13:6536)
    at Player.init (/home/pierre/Documents/museeks/dist/main/bundle.js:130:29716)
    at new Player (/home/pierre/Documents/museeks/dist/main/bundle.js:130:29497)
    at Player (/home/pierre/Documents/museeks/dist/main/bundle.js:130:29346)
    at new MprisModule (/home/pierre/Documents/museeks/dist/main/bundle.js:417:129483)
    at /home/pierre/Documents/museeks/dist/main/bundle.js:417:136413
    at /home/pierre/Documents/museeks/dist/main/bundle.js:417:134144
(node:3444) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:3444) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

martpie · 2019-03-13T16:29:05Z

@acrisci Any idea what could go wrong here? When editing the module directly and forcing it to be 'unix:path=/var/run/dbus/system_bus_socket', other errors are thrown.

acrisci · 2019-03-13T17:08:18Z

You should be running this on the session bus which for me is at /run/user/$UID/bus.

The dbus library should be reading the DBUS_SESSION_BUS_ADDRESS environment variable for the path of the session bus.

$ echo $DBUS_SESSION_BUS_ADDRESS 
unix:path=/run/user/1000/bus

I'm looking at the code for dbus-next and it might not actually be doing that. It might just be trying to read it from the x11 property, but I need to look into that.

If you're running this on Wayland, that's not tested and may introduce some bugs that need to be fixed.

Looking into all of this now.

acrisci · 2019-03-13T17:45:25Z

I looked into dbus-next and confirmed it is reading DBUS_SESSION_BUS_ADDRESS for the session bus address. You will get this error only when that environment variable is not set.

None of the X11 code is working, so that's pretty much the only way to specify the bus address right now.

The session manager should be starting dbus (like with dbus-launch) to start the bus and setting those variables but yours might not be doing that. My stock 18.04 does set those variables, but I didn't test with elementary. This might be their bug, but getting the dbus-next X11 code working might fix this (unless they use Wayland and don't have X11 support compiled into their dbus libraries, which is a possibility).

martpie · 2019-03-13T18:33:48Z

thanks; I'll investigate on my side why they are not set!

igorer88 · 2019-03-13T22:46:54Z

@acrisci Mint 19.1 is based on Ubuntu 18.04. So if it works there, it should work in here too. I agree with you on fixing dbus-next X11 would solve the problem.

martpie · 2019-03-13T23:06:07Z

I don't think it is a X11 problem, because mpris-service@1.4 worked fine. This problem is only with mpris-service@2.0.0.

Maybe a missing DE dependency...

acrisci · 2019-03-14T00:00:08Z

I did a detailed writeup on the issue on dbus-next here.

martpie · 2019-03-26T12:47:11Z

With dbus-next@0.4.1, the error is a bit more precise:

(node:5641) UnhandledPromiseRejectionWarning: Error: could not get DISPLAY environment variable to get dbus address
    at getDbusAddressFromFs (/home/pierre/Documents/museeks/dist/main/bundle.js:417:25058)
    at /home/pierre/Documents/museeks/dist/main/bundle.js:13:5792
    at createConnection (/home/pierre/Documents/museeks/dist/main/bundle.js:13:6896)
    at Object.module.exports.createClient (/home/pierre/Documents/museeks/dist/main/bundle.js:13:7771)
    at Object.module.exports.sessionBus (/home/pierre/Documents/museeks/dist/main/bundle.js:13:8096)
    at Player.init (/home/pierre/Documents/museeks/dist/main/bundle.js:130:43113)
    at new Player (/home/pierre/Documents/museeks/dist/main/bundle.js:130:42894)
    at Player (/home/pierre/Documents/museeks/dist/main/bundle.js:130:42743)
    at new MprisModule (/home/pierre/Documents/museeks/dist/main/bundle.js:417:132442)
    at /home/pierre/Documents/museeks/dist/main/bundle.js:417:139372
(node:5641) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:5641) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

(Ubuntu 18.04.2)

acrisci · 2019-03-26T12:59:17Z

I've run the mpris-service integration test suite on stock Ubuntu 18.04 and it works fine. Both the DISPLAY environment variable is set and the session manager sets DBUS_SESSION_BUS_ADDRESS.

Can you give me some more info on your setup so I can try to reproduce the issue?

martpie · 2019-03-26T14:44:31Z

Ah, interesting thing, I am running the Communitheme snap session. Let me try with the default one.

martpie · 2019-03-26T14:46:19Z

Mmh getting the same with the classic session, let me try with a fresh install.

martpie · 2019-03-26T15:59:04Z

Getting the same issue on a fresh install. I guess there is a problem with the environment variables then. Maybe Wepback is doing something nasty.

I am now trying to not bundle node-dbus-next so it is called from node_modules.

martpie · 2019-03-26T16:03:51Z

➜  museeks git:(mpris) ✗ echo $DISPLAY
:0

Does it look good?

@acrisci How do you usually get the DISPLAY environment variable with Node.js?

martpie · 2019-03-26T16:41:57Z

ok, process.env is returning all the good results when asking the node prompt, but is only returning { NODE_ENV: 'production' } when running the app after bundling it.

I think Wepback or Electron is somewhat sanitizing these variables at build/runtime.

I need to find a way to let these variables be accessible at runtime

martpie · 2019-03-27T14:59:02Z

BAM! Now mpris-service needs an update because of 0.4's breaking changes, but I guess we're almost good to go.

The problem was indeed Webpack, and more specifically the DefinePlugin:

new webpack.DefinePlugin({
  'process.env': {
    NODE_ENV: '"development"',
  },
}),

Would replace all process.env by the provided object in the bundle.

martpie · 2019-03-27T15:41:52Z

Et voilà. A couple of bugfixes to do and I guess we're good.

martpie · 2019-03-27T16:36:59Z

Closed by #477 🎉

Base64 covers are not supported, but I guess it's fine for now.

igorer88 · 2019-03-27T21:27:46Z

Wow!! Excellent!! 👍

martpie added enhancement help wanted linux PR appreciated labels Jun 30, 2016

martpie mentioned this issue Jun 30, 2016

Better system integration on Windows #73

Closed

YurySolovyov mentioned this issue Aug 12, 2016

Add tests dbusjs/mpris-service#7

Closed

martpie mentioned this issue Sep 21, 2016

Museeks 1.0 #220

Open

18 tasks

martpie changed the title ~~Better system integration on Ubuntu/Gnome~~ Integrate mpris Apr 4, 2018

martpie mentioned this issue Apr 4, 2018

Feature Request: Media button functionality #431

Closed

martpie mentioned this issue Jun 2, 2018

a multitude of items that I personal would add if I knew how to and where the developer #452

Closed

martpie mentioned this issue Aug 19, 2018

Re-think Tray, close behavior and frame #457

Closed

3 tasks

martpie added the Museeks 1.0 label Aug 19, 2018

martpie added this to the 1.0 milestone Aug 19, 2018

martpie removed the PR appreciated label Feb 17, 2019

RicardoEPRodrigues mentioned this issue Mar 2, 2019

Enhancement: Integration MPRIS on Linux Dinius/Brain.fm-Desktop-Client#16

Open

martpie removed this from the 1.0 milestone Mar 2, 2019

martpie added this to the 0.11 milestone Mar 2, 2019

acrisci mentioned this issue Mar 13, 2019

Get session bus address from X11 dbusjs/node-dbus-next#14

Open

martpie closed this as completed Mar 27, 2019

Kazun3500 mentioned this issue May 31, 2019

What about Mpris integration dedpnd/yaradio-yamusic#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate mpris #93

Integrate mpris #93

martpie commented Jun 30, 2016 •

edited

Loading

YurySolovyov commented Aug 12, 2016

vprigent commented Sep 12, 2016

YurySolovyov commented Sep 12, 2016

vprigent commented Sep 12, 2016

martpie commented Sep 12, 2016 •

edited

Loading

vprigent commented Sep 12, 2016

mhanoglu commented Apr 7, 2017

martpie commented Apr 7, 2017

mhanoglu commented Apr 8, 2017

martpie commented Feb 6, 2018 •

edited

Loading

martpie commented Feb 6, 2018 •

edited

Loading

martpie commented Apr 4, 2018

YurySolovyov commented Feb 21, 2019

igorer88 commented Mar 1, 2019

martpie commented Mar 13, 2019 •

edited

Loading

martpie commented Mar 13, 2019

acrisci commented Mar 13, 2019

acrisci commented Mar 13, 2019

martpie commented Mar 13, 2019

igorer88 commented Mar 13, 2019

martpie commented Mar 13, 2019 •

edited

Loading

acrisci commented Mar 14, 2019

martpie commented Mar 26, 2019

acrisci commented Mar 26, 2019

martpie commented Mar 26, 2019 •

edited

Loading

martpie commented Mar 26, 2019

martpie commented Mar 26, 2019

martpie commented Mar 26, 2019 •

edited

Loading

martpie commented Mar 26, 2019 •

edited

Loading

martpie commented Mar 27, 2019 •

edited

Loading

martpie commented Mar 27, 2019

martpie commented Mar 27, 2019

igorer88 commented Mar 27, 2019 •

edited

Loading

Integrate mpris #93

Integrate mpris #93

Comments

martpie commented Jun 30, 2016 • edited Loading

YurySolovyov commented Aug 12, 2016

vprigent commented Sep 12, 2016

YurySolovyov commented Sep 12, 2016

vprigent commented Sep 12, 2016

martpie commented Sep 12, 2016 • edited Loading

vprigent commented Sep 12, 2016

mhanoglu commented Apr 7, 2017

martpie commented Apr 7, 2017

mhanoglu commented Apr 8, 2017

martpie commented Feb 6, 2018 • edited Loading

martpie commented Feb 6, 2018 • edited Loading

martpie commented Apr 4, 2018

YurySolovyov commented Feb 21, 2019

igorer88 commented Mar 1, 2019

martpie commented Mar 13, 2019 • edited Loading

martpie commented Mar 13, 2019

acrisci commented Mar 13, 2019

acrisci commented Mar 13, 2019

martpie commented Mar 13, 2019

igorer88 commented Mar 13, 2019

martpie commented Mar 13, 2019 • edited Loading

acrisci commented Mar 14, 2019

martpie commented Mar 26, 2019

acrisci commented Mar 26, 2019

martpie commented Mar 26, 2019 • edited Loading

martpie commented Mar 26, 2019

martpie commented Mar 26, 2019

martpie commented Mar 26, 2019 • edited Loading

martpie commented Mar 26, 2019 • edited Loading

martpie commented Mar 27, 2019 • edited Loading

martpie commented Mar 27, 2019

martpie commented Mar 27, 2019

igorer88 commented Mar 27, 2019 • edited Loading

martpie commented Jun 30, 2016 •

edited

Loading

martpie commented Sep 12, 2016 •

edited

Loading

martpie commented Feb 6, 2018 •

edited

Loading

martpie commented Feb 6, 2018 •

edited

Loading

martpie commented Mar 13, 2019 •

edited

Loading

martpie commented Mar 13, 2019 •

edited

Loading

martpie commented Mar 26, 2019 •

edited

Loading

martpie commented Mar 26, 2019 •

edited

Loading

martpie commented Mar 26, 2019 •

edited

Loading

martpie commented Mar 27, 2019 •

edited

Loading

igorer88 commented Mar 27, 2019 •

edited

Loading