Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on Google Play Services for Location #49

Closed
icasdri opened this issue Jan 31, 2016 · 2 comments
Closed

Dependency on Google Play Services for Location #49

icasdri opened this issue Jan 31, 2016 · 2 comments

Comments

@icasdri
Copy link
Contributor

icasdri commented Jan 31, 2016

A dependency on the proprietary Google Play Services seems to have been introduced by 32ef745 in #40 for resolving coarse location. I wonder if it is possible to resolve location without these services, as introducing such a dependency has a couple important consequences, especially considering Forecastie is aiming to be a FOSS app:

  1. Users of fully-free (or otherwise Google-free) roms would be unable to use our app.
  2. We might get kicked from F-Droid (or F-Droid would have to maintain a separate branch with the proprietary services stripped out).

We may also look into configurable solutions, such as a setting to configure location provider, or as a stop-gap, a setting that guards against importing or creating the proprietary GoogleAPIClient (using dynamic import measures or otherwise). If desirable, I will spend some time looking into this.

@martykan
Copy link
Owner

I would abolish Google Play Services totally and use the native location services. I will work on it.

@martykan
Copy link
Owner

martykan commented Feb 2, 2016

Fixed now, full freedom regained.

@martykan martykan closed this as completed Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants