Added message auto encoding #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of making |
| buffer += chunk; | ||
| var lines = buffer.split("\r\n"); | ||
| buffer = lines.pop(); | ||
| if (typeof(chunk) == 'string') { |
There was a problem hiding this comment.
nitpick: strict equality is better
|
In an effort to get the project back on track and always have I've written a wikipage at https://github.com/martynsmith/node-irc/wiki/0.3.x-branch-debacle to try and help with the transition. Thanks! |
|
If you'd like I can reopen this PR for you and pull in your commits from your fork. |
|
Go ahead. |
|
Or wait, I'll make new one for the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will "normalize" all messages to UTF-8 encoding. Related to #157 #85 #113