Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to use Settings API #1

Closed
psifertex opened this issue Oct 21, 2020 · 3 comments
Closed

Suggestion to use Settings API #1

psifertex opened this issue Oct 21, 2020 · 3 comments

Comments

@psifertex
Copy link

psifertex commented Oct 21, 2020

Rather than a local metadata store, might I recommend using the Settings API? The advantage is if the plugin is removed / reinstalled, the previous settings will be maintained. Here's an example plugin that uses the Settings API:

https://github.com/withzombies/bnil-graph/blob/master/__init__.py#L21-L48

Likewise, you might consider using something like Path(user_plugin_path()) / ".." / "ghinja_projects" as a good folder versus ~/.ghinja_projects for better cross-platform portability. (IE, .dot files not being standard on windows)

@Martyx00
Copy link
Owner

Thanks! Both suggestions will be taken into account for next release along other improvments and fixes. Unfortunately I dont have ETA on that as the development is done in my free time only.

@psifertex
Copy link
Author

No worries, totally understand. I might throw a PR together too if I get some time knowing you're amenable.

@Martyx00
Copy link
Owner

Both suggestions and the raw image for the plugin manager were addressed by ab02653. I will try to implement couple more fixes before making the 0.2 release (or 1.0 if I will feel confident enough).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants