Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation link in crates.io is broken #97

Closed
pmatos opened this issue Apr 11, 2017 · 7 comments
Closed

Documentation link in crates.io is broken #97

pmatos opened this issue Apr 11, 2017 · 7 comments

Comments

@pmatos
Copy link

pmatos commented Apr 11, 2017

https://crates.io/crates/parser-combinators links to https://marwes.github.io/parser-combinators/parser_combinators/index.html which doesn't exist.

@Marwes
Copy link
Owner

Marwes commented Apr 11, 2017

I suppose I could change it to point to https://docs.rs/parser-combinators/0.7.0/parser_combinators/ but there is practically no reason to be using such an old version of the library. I really recommend using at least combine-1.0.0 at least. https://crates.io/crates/combine

@Marwes
Copy link
Owner

Marwes commented Apr 11, 2017

Oops, actually the documentation link on https://crates.io/crates/combine is actually wrong as well, it should point to https://docs.rs/combine/2.3.1/combine/

@pmatos
Copy link
Author

pmatos commented Apr 11, 2017

Argh, I didn't notice parser_combinators was forwarding me to combine. Thanks for your time. Maybe parser_combinators could be removed from crates.io?

@Marwes
Copy link
Owner

Marwes commented Apr 11, 2017

Can't really remove it since there might be people that still need (there are a download of it every now and then). Could maybe add DEPRECEATED in the description so it is more eye catching.

@pmatos
Copy link
Author

pmatos commented Apr 11, 2017

Sounds like a good idea. If possible, for new users, some explicit text pointing them to use combine instead.

@Marwes
Copy link
Owner

Marwes commented Apr 12, 2017

Fixed with 60bfe8e and c93b81a

@Marwes Marwes closed this as completed Apr 12, 2017
@pmatos
Copy link
Author

pmatos commented Apr 12, 2017

@Marwes Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants