Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

narray fail to build in windows with mingw tool #2

Closed
sgwong opened this issue Dec 23, 2010 · 1 comment
Closed

narray fail to build in windows with mingw tool #2

sgwong opened this issue Dec 23, 2010 · 1 comment

Comments

@sgwong
Copy link

sgwong commented Dec 23, 2010

The Makefile generate with current extconf.rb file not able to build in Windows with mingw tool. The following modification will make it build and install in windows with mingw.(tested in Windows 7 64 bit ruby 1.9.2)

@@ -54,7 +54,7 @@

 if /cygwin|mingw/ =~ RUBY_PLATFORM
   if RUBY_VERSION > '1.8.0'
-    $DLDFLAGS << ",--out-implib=libnarray.a"
+    $DLDFLAGS << " -Wl,--out-implib=libnarray.a"
   elsif RUBY_VERSION > '1.8'
     CONFIG["DLDFLAGS"] << ",--out-implib=libnarray.a"
     system("touch libnarray.a")  
@masa16
Copy link
Owner

masa16 commented Jan 4, 2011

Thank you for the patch. This is fixed at the branch head.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants