Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove method shorthand from Dict #261

Closed
masak opened this issue Sep 20, 2017 · 4 comments
Closed

Remove method shorthand from Dict #261

masak opened this issue Sep 20, 2017 · 4 comments
Labels
currently-blocked good first issue low-hanging fruit

Comments

@masak
Copy link
Owner

masak commented Sep 20, 2017

After #242 is merged, we might want to remove the method shorthand on the Dict type. I don't see a big need for declaring "methods" on dictionaries, now that Object and Dict have separated. People are much more likely to declare methods using the class syntax from now on.
@sergot
Copy link
Collaborator

sergot commented Oct 18, 2017

Why is it currently blocked? :)

@vendethiel
Copy link
Collaborator

Because #242 wasn't merged I guess

@masak
Copy link
Owner Author

masak commented Oct 19, 2017

What @vendethiel said. Currently the master branch doesn't have a Dict type. This issue was one of the things belonging to the separation of the Object and Dict types, but it's not a hard requirement for #242, which is already rather huge.

@sergot
Copy link
Collaborator

sergot commented Oct 19, 2017

Oh I didn't notice, thanks!

@masak masak mentioned this issue Feb 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
currently-blocked good first issue low-hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@masak @vendethiel @sergot