Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-make .identifier as .name on ops #413

Closed
masak opened this issue Oct 24, 2018 · 3 comments
Closed

Re-make .identifier as .name on ops #413

masak opened this issue Oct 24, 2018 · 3 comments

Comments

@masak
Copy link
Owner

masak commented Oct 24, 2018

Why do we store the identifier, the way to get at the routine that we're actually interested in? I dunno, historical reasons, perhaps... Anyway, it should be the routine itself.

It's also interesting to think how this affects the qtype property in unquotes, and the identifier property in object terms, both mentioned in #359. Maybe they should also be referring directly to their thing?

@masak
Copy link
Owner Author

masak commented Oct 26, 2018

...no. Closing.

The correct hook to hang an operator on is as a symbol lookup in a scope. Because in the general case, we don't have the actual routine, because the operator was declared as e.g. a parameter.

Maybe in the other two cases there's less dynamism, but I'm not so sure about that either.

@masak masak closed this as completed Oct 26, 2018
@masak
Copy link
Owner Author

masak commented Oct 30, 2018

Hm, but it should actually be a name, not an identifier, because in

test.assert foo(), 42;

test.assert is a prefix operator, not a term. Hmmmmmmmm.

@masak masak changed the title Re-make .identifier as .routine on ops Re-make .identifier as .name on ops Oct 30, 2018
@masak masak reopened this Oct 30, 2018
@masak
Copy link
Owner Author

masak commented Nov 10, 2018

Nope. See #417 (comment).

@masak masak closed this as completed Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant