Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show wail popup on the frontground of all other windows #615

Open
Thykof opened this issue Aug 18, 2023 · 4 comments
Open

Show wail popup on the frontground of all other windows #615

Thykof opened this issue Aug 18, 2023 · 4 comments

Comments

@Thykof
Copy link
Contributor

Thykof commented Aug 18, 2023

Context
Describe / explain why we should do this: motivations, context or other info. Keep it brief and simple - PM

When a user interacts with a dapp and the dapp wants to sign an operation, the wail popup is showed on the background, behind other windows.

User flow

  • User initiates signature popup via a dapp
  • Every wail popup must show directly on top of all opened windows.
  • at least, on mac os, move to the desktop where the wails popup is, if possible

How to

Technical details
There might be a wail parameter to show the popup on top of other windows: this solution is not acceptable, see #704

QA testing
Does this task require some QA tests ?
If yes, explain how to validate it

@thomas-senechal
Copy link
Member

Couldn't reproduce on MacOS and Windows. The windows opened by the wallet are shown on top

If we want, we could force windows to be always on top using the AlwaysOnTop option

@pivilartisant pivilartisant self-assigned this Sep 12, 2023
@pivilartisant pivilartisant linked a pull request Sep 12, 2023 that will close this issue
@loonggamma
Copy link
Contributor

loonggamma commented Sep 15, 2023

@pivilartisant do we need to move this issue to q/a? what's the status here?

@pivilartisant
Copy link
Contributor

@pivilartisant do we need to move this issue to q/a? what's the status here?

cc @Thykof

@Thykof
Copy link
Contributor Author

Thykof commented Sep 15, 2023

@longgamma-massa nothing to QA for now, still in TODO, needs research and UX/UI discussion about what is needed and what is possible to achieve, on the 3 OS

@loonggamma loonggamma added should-have and removed P2 labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants